Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

44 timestamp conversion fail after switching to new api #45

Merged
merged 6 commits into from
Jun 10, 2024
Merged

44 timestamp conversion fail after switching to new api #45

merged 6 commits into from
Jun 10, 2024

Conversation

janstarke
Copy link
Member

fixes #44.

The problem was that version 0.4.35 of chronotope/chrono removes all methods that allow to import a timestamp from another timezone than UTC (https://github.com/chronotope/chrono/releases/tag/v0.4.35):

We deprecated all timestamp-related methods on NaiveDateTime. The reason is that a timestamp is defined to be in UTC. The NaiveDateTime type doesn't know the offset from UTC, so it was technically wrong to have these methods. The alternative is to use the similar methods on the DateTime<Utc> type, or from the TimeZone trait.

So, this functionality has also been removed from dfir-toolkit and -- especially -- from mactime2.

@janstarke janstarke added the bug Something isn't working label May 17, 2024
@janstarke janstarke added this to the 0.10.4 milestone May 17, 2024
@janstarke janstarke requested a review from Explie May 17, 2024 10:23
@janstarke janstarke linked an issue May 17, 2024 that may be closed by this pull request
timestamp conversion fail after switching to new API #44
Closed
Explie
Explie requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@Explie Explie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown Help generation with clap fails

@Explie Explie mentioned this pull request Jun 10, 2024
Closed
@janstarke janstarke merged commit e978e71 into develop Jun 10, 2024
4 checks passed
@janstarke janstarke deleted the 44-timestamp-conversion-fail-after-switching-to-new-api branch June 10, 2024 13:21
@janstarke janstarke modified the milestones: 0.10.5, 0.11.0 Jun 10, 2024
@janstarke
Copy link
Member Author

fixes #44

@janstarke janstarke mentioned this pull request Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Explie Explie Explie approved these changes

Assignees

@Explie Explie

Labels
bug Something isn't working
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

timestamp conversion fail after switching to new API
2 participants
@janstarke @Explie