fix ndim=1 error in samplerKwargs #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for these fixes and quality-of-life improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
samplerKwargs["ndim"] = ap.theta.shape[-1]in mcmcUtils.py causes an error ifndim=1since theta is stored asself.theta = np.array(theta).squeeze()in line 87 of approx.py which changes the shape of theta from (nsamples,1) to (nsamples,). So for 1D, ndim is being set tosamplerKwargs["ndim"]=nsamples, notsamplerKwargs["ndim"]=1.