Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new method to deal with leaving from the end #110

Merged
merged 6 commits into from Sep 14, 2020
Merged

Conversation

jalal246
Copy link
Member

@jalal246 jalal246 commented Sep 11, 2020

This PR makes vertical movement bug free covering three scenarios:

  • dragged is leaving from the end/top.
  • dragged is entering from the end/top.
  • dragged is going up/down inside the list container.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020

Codecov Report

Merging #110 into master will decrease coverage by 1.87%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   61.16%   59.29%   -1.88%     
==========================================
  Files          17       17              
  Lines         412      425      +13     
  Branches       64       68       +4     
==========================================
  Hits          252      252              
- Misses        131      143      +12     
- Partials       29       30       +1     
Impacted Files Coverage Δ
packages/dnd/src/Draggable/Base.js 93.87% <ø> (ø)
packages/dnd/src/Draggable/Draggable.js 54.83% <0.00%> (-6.98%) ⬇️
packages/dnd/src/Droppable/Droppable.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2368e3...e3cc59f. Read the comment docs.

@jalal246 jalal246 added the enhancement New feature or request label Sep 12, 2020
@jalal246 jalal246 changed the title Patches/dnd Add new method to deal with leaving from the end Sep 12, 2020
@jalal246 jalal246 merged commit a4580b9 into master Sep 14, 2020
@jalal246 jalal246 deleted the patches/dnd branch September 14, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug when dragged is leaving from the end and returning back to the list container
2 participants