Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add element visibility to calculations #293

Merged
merged 19 commits into from Jul 23, 2021
Merged

Conversation

jalal246
Copy link
Member

@jalal246 jalal246 commented Jul 22, 2021

  • Remove text selection from the entire document when starting dragging.
  • Remove unnecessary getOffset method from core-instance.
  • Add ability to reset DOMRect from outside the core-instance.
  • core-instance accepts opts now.
  • Add custom dataset data-index which refers to element order inside rendering list after the transform is calculated. We have now original order in the DOM tree and a transformation order related to elements' appearance on the screen.
  • Introduce element visibility which is true when the element is visible on the viewport.
    • Calculate element visibility with scrolling.
    • Update element position in the store but don't transform when the element is hidden.
    • Invoke transformer when the element is visible,. Which is done with scrolling.
    • Scroll is throttled to the animated frame.
    • Add visibility exceptions to enhance UX. Immediate elements before and after the visible elements are isVisible: true
    • Done with adding new methods:
      • Inside the store:
        setViewport
        setScrollXY
        initELmIndicator
        isElementHiddenInViewport
        updateRegisteredLayoutIndicators
    • Inside the core-instance:
      visibilityHasChanged
  • Refactor Jest Snapshots to include the new changes.

@jalal246 jalal246 added the enhancement New feature or request label Jul 22, 2021
@jalal246 jalal246 linked an issue Jul 23, 2021 that may be closed by this pull request
@jalal246 jalal246 merged commit e84ec25 into master Jul 23, 2021
@jalal246 jalal246 deleted the dev/next_release_beta_0 branch July 23, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant