Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce passing id and parentID for registered elements #555

Merged
merged 17 commits into from
Jun 8, 2022

Conversation

jalal246
Copy link
Member

@jalal246 jalal246 commented Jun 4, 2022

  • Use *.test.tsx for unit testing instead of mocking DOM elements.
  • Replace @swc/jest with ts-jest as the tsx kept failing for no reason. Also this Starting from v28.0.0, ts-jest will gradually opt in adoption of esbuild/swc more to improve the performance.
  • keep all shared dependencies inside the package.json in the root directory.
  • Refactor playground using shared DFlexDnDComponent for all cases.
  • Start Using underscore-dangle for private properties.
  • Remove ref from registry input options and depends only on id which is required now along with parentID.

@github-actions github-actions bot added the Store label Jun 5, 2022
@jalal246 jalal246 changed the title Dev Enforce passing id and parentID for registered elements Jun 8, 2022
@jalal246 jalal246 merged commit 284614d into main Jun 8, 2022
@jalal246 jalal246 deleted the dev/wip_6_4_p2 branch June 8, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant