Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for SameSite=None. Updated tests. #36

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

MrDys
Copy link
Contributor

@MrDys MrDys commented Jan 2, 2020

This PR adds None as a possible value for the SameSite setting. Per the spec, None is a valid value and is needed when explicitly permitting cross-site cookie delivery.

@simensen
Copy link
Member

simensen commented Jan 2, 2020

@MrDys Thanks!

@Ocramius What say you? :)

Copy link
Contributor

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simensen simensen merged commit 733af78 into dflydev:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants