-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option for log scaled axes. #174
Conversation
@castillohair: Thanks for this! Two major comments immediately:
|
@dfm Thanks for your response! I'll try to implement your comments some time this week and get back to you. |
@castillohair has there been any progress on this? It would be an incredibly useful feature. |
fb16952
to
5f98a50
Compare
for more information, see https://pre-commit.ci
Hi everybody, Sorry for the massive delay. I updated my log-scale branch to be based on the most recent main. My example code above runs with this branch as specified. Furthermore, the @dfm Let me know if this looks good and what else needs to be done to be merged. @Rodot- and everybody else reading this: I guess you could test this immediately by downloading from https://github.com/castillohair/corner.py/tree/log-scale, at your own risk since I don't have the thumbs up from the package owner just yet. |
@castillohair — Thanks for the update! It would be great to add a test for this new feature in |
I added log versions of some of the tests already present, the ones I thought were the most relevant. Let me know what you think! |
This is perfect! I'm happy to merge this now. Thanks @castillohair! |
Solves #85
Log-scaled axes can be used via the
axes_scale
argument as indicated below: