Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all calls to contour have sorted levels #70

Merged
merged 3 commits into from
Jan 12, 2016
Merged

Conversation

zblz
Copy link
Contributor

@zblz zblz commented Jan 12, 2016

With these changes, all calls to plt.contourf have sorted levels (see matplotlib/matplotlib#5477 and matplotlib/matplotlib#5485). This allows to use corner in matplotlib > 1.5.0.

Fixes #65 and #68

@drphilmarshall
Copy link

Go Victor! :-)

On Tuesday, January 12, 2016, Victor Zabalza notifications@github.com
wrote:

With these changes, all calls to plt.contourf have sorted levels (see
matplotlib/matplotlib#5477
matplotlib/matplotlib#5477 and
matplotlib/matplotlib#5485
matplotlib/matplotlib#5485). This allows to use
corner in matplotlib > 1.5.0.

Fixes #65 #65 and #68

#68

You can view, comment on, or merge this pull request online at:

#70
Commit Summary

  • sort levels in hist2d

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#70.

@dfm
Copy link
Owner

dfm commented Jan 12, 2016

Thanks Victor. Unfortunately this isn't quite right. For example, for the hist2d_filled test case in tests.py, this gives:
hist2d_filled
which is better, I agree, than it used to be but the final level should be transparent not black.

I'm happy to look into this but I won't have a chance for at least a week and possibly more so you should give it a try if you have time :-)

Thanks again for this contribution!

@zblz
Copy link
Contributor Author

zblz commented Jan 12, 2016

@dfm: I just realised that, and fixed it in 72bac6f! The colormap was being built in decreasing order.

I now get this:

hist2d_filled

@dfm
Copy link
Owner

dfm commented Jan 12, 2016

Excellent! That looks better! Just add your name to corner.__contributors__ and I'll merge.

@zblz
Copy link
Contributor Author

zblz commented Jan 12, 2016

@dfm: Done!

edit: Also, I think this deserves a bugfix release, otherwise with matplotlib 1.5.1 out as stable reseale quite a lot of people will find bug #68

@dfm dfm merged commit 73eeff1 into dfm:master Jan 12, 2016
@dfm
Copy link
Owner

dfm commented Jan 12, 2016

Thanks! I've pushed a new 1.0.1 release to pypi.

@tacaswell
Copy link
Contributor

👍 Thanks @zblz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants