Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is numpy required for SETUP_REQUIRES #426

Closed
BastianZim opened this issue May 5, 2022 · 4 comments · Fixed by #427
Closed

Is numpy required for SETUP_REQUIRES #426

BastianZim opened this issue May 5, 2022 · 4 comments · Fixed by #427

Comments

@BastianZim
Copy link
Contributor

Hi,

currrently, SETUP_REQUIRES lists numpy as specified here:

emcee/setup.py

Line 26 in bee076f

SETUP_REQUIRES = INSTALL_REQUIRES + [

I don't see any place where this is actually used during building though so I was wondering if that could be removed.

Thanks!
@dfm
Copy link
Owner

dfm commented May 5, 2022

Good point - I have some vague recollection that that was added for a reason, but it definitely seems unnecessary!

@BastianZim
Copy link
Contributor Author

Happy with me putting in a PR?

@dfm
Copy link
Owner

dfm commented May 5, 2022

Please do!

@BastianZim BastianZim mentioned this issue May 5, 2022
Merged
@BastianZim
Copy link
Contributor Author

PR is in #427

@dfm dfm closed this as completed in #427 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove NumPy from SETUP_REQUIRES BastianZim/emcee
2 participants
@dfm @BastianZim