Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove enum34 from requirements #4

Merged
merged 2 commits into from
Jun 19, 2020
Merged

remove enum34 from requirements #4

merged 2 commits into from
Jun 19, 2020

Conversation

eeshugerman
Copy link

@eeshugerman eeshugerman commented Jun 8, 2020

I'm working on DWP-1992 and this package is giving pip-compile a hard time. From what I can tell it is a drop-in replacement for the builtin enum module in Python 3.4+, so these days should only be used for backwards compatibility. Apparently it is known to cause issues with a lot of packages. Finally, from what I can tell (using GitHub search), it isn't imported anywhere in this repo.

Still need to give TTD a test run with this change. ✔️

@eeshugerman eeshugerman marked this pull request as ready for review June 12, 2020 21:57
@mschmo
Copy link

mschmo commented Jun 19, 2020

word - I had additionally manually uninstalled that enum34 package on our servers as it was causing errors when pip installing from docs/sphinx/requirements.txt:
Screen Shot 2020-06-19 at 3 43 45 PM

@mschmo mschmo merged commit 3fed1ed into dfmedia:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants