Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use [KINWebBrowserViewController class] instead of [self class]. #57

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Use [KINWebBrowserViewController class] instead of [self class]. #57

merged 1 commit into from
Apr 6, 2017

Conversation

mattia
Copy link
Contributor

@mattia mattia commented May 31, 2016

Using [KINWebBrowserViewController class] instead of [self class] allows to retrieve back/forward images correctly when subclassing KINWebBrowserViewController.
If you subclass KINWebBrowserViewController (including it in your application using CocoaPods with framework) the path to the image resource could be wrong. This fixes the problem.

Using [KINWebBrowserViewController class] instead of [self class] allows to retrieve back/forward images correctly when subclassing KINWebBrowserViewController.
If you subclass KINWebBrowserViewController (including it in your application using CocoaPods with framework) the path to the image resource could be wrong. This fixes the problem.
@maxoly
Copy link

maxoly commented May 31, 2016

+1

@wei
Copy link

wei commented Jun 15, 2016

Temporary Workaround:

  1. Drag backbutton & forwardbutton to your project
  2. Override viewWillAppear
override func viewWillAppear(animated: Bool) {
    super.viewWillAppear(animated)

    self.navigationController?.toolbar.items?[0].image = UIImage(named: "backbutton")
    self.navigationController?.toolbar.items?[2].image = UIImage(named: "forwardbutton")
}

@wei wei mentioned this pull request Jun 15, 2016
@edwinruan
Copy link

edwinruan commented Apr 5, 2017

This pull request is a correct fix to the problem. Please have it merged and have a new version.

@dfmuir dfmuir merged commit 89ff0fc into dfmuir:master Apr 6, 2017
@edwinruan
Copy link

edwinruan commented Apr 6, 2017

@dfmuir Thank you very much for the quick action and merging!

@mattia mattia deleted the fix-subclass branch May 24, 2017 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants