Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quadtree(): add minimal support for SpatRaster input #7 #16

Merged
merged 1 commit into from
May 13, 2023

Conversation

brownag
Copy link
Contributor

@brownag brownag commented May 12, 2023

Hi! Thanks for this great package.

I've switched essentially all my raster workflows to terra now and it would be convenient if quadtree() accepted the SpatRaster directly. So here is a 1-liner that adds support for SpatRaster inputs RE: #7.

I am not sure whether you have plans to rewrite internals that currently use raster with terra (which would of course be a bigger job). I would be happy to contribute PR(s) that front if you want to try and go that direction.

Otherwise something like this PR should cover most use cases; minimally allowing SpatRasters to be converted to RasterLayer, then to Quadtree.

@dfriend21 dfriend21 merged commit bdf4ec0 into dfriend21:master May 13, 2023
@dfriend21
Copy link
Owner

Thanks! I've also switched to terra, so I agree that it would great to switch all of the raster-related functionality to terra. This'll at least serve as a stop-gap measure.

I'd love to get it switched over. However, this project isn't a central part of my work anymore, so any updates to it will have to happen on my free time - so unfortunately I can't guarantee promptness on this front. So any PRs concerning this issue (or any others) would be greatly appreciated!

@brownag brownag deleted the brownag-fix-terra-compat-7 branch May 15, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants