Symmetrical colorbars are drawn incorrectly

[dfsp-spirit]

There is something wrong with the visualization of symmetric color legends. Needs investigation.

For an example, draw a colorbar using the unit test for vis.symmetric.data.on.subject that uses the cluster data.

Reproducible example:

subjects_dir = file.path(find.freesurferhome()$found_at, 'subjects');
subject_id = 'fsaverage';

lh_demo_cluster_file = system.file("extdata", "lh.clusters_fsaverage.mgz", package = "fsbrain", mustWork = TRUE);
rh_demo_cluster_file = system.file("extdata", "rh.clusters_fsaverage.mgz", package = "fsbrain", mustWork = TRUE);

lh_clust = freesurferformats::read.fs.morph(lh_demo_cluster_file);   # contains a single positive cluster (activation, group difference), the other values are 0
rh_clust = freesurferformats::read.fs.morph(rh_demo_cluster_file);   # contains two negative clusters

vis.symmetric.data.on.subject(subjects_dir, subject_id, lh_clust, rh_clust, bg="curv", draw_colorbar = T);

[dfsp-spirit]

This was a bug caused by passing the colors of the mesh instead of the color function to fields::imageplot. It was very apparent in the example above because many of the colors are NA for the cluster data, but in general, it was present in all colorbars.

This is fixed in the develop branch now, but needs some more testing to be sure it really works under all conditions. It will be part of the next release.

Note: As it is not in the master branch yet, installing from Github does not fix this (unless you install the develop branch, which is not recommended).

[dfsp-spirit]

This is fixed in the master branch and in release v0.2.1, which is now on CRAN. Closing.