Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmo features #1119

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Cosmo features #1119

wants to merge 2 commits into from

Conversation

aradi
Copy link
Member

@aradi aradi commented Oct 3, 2022

Contains some Cosmo features

  • Calculate volume based on the divergence theorem
  • Fix surface area calculation to take the switch-function into account
  • Fix sign in dielectrics
  • Fix the issue with the epsilon, which is calculated differently as in the original COSMO papers (and seem to contain a factor of 1/2)

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 69.32% // Head: 69.33% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (48ce9d1) compared to base (4be1e81).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1119   +/-   ##
=======================================
  Coverage   69.32%   69.33%           
=======================================
  Files         220      220           
  Lines       40623    40640   +17     
=======================================
+ Hits        28162    28177   +15     
- Misses      12461    12463    +2     
Impacted Files Coverage Δ
src/dftbp/dftbplus/initprogram.F90 82.52% <ø> (ø)
src/dftbp/solvation/solvinput.F90 87.50% <ø> (ø)
src/dftbp/solvation/cosmo.F90 89.80% <100.00%> (+0.72%) ⬆️
src/dftbp/math/ranlux.F90 57.84% <0.00%> (-1.97%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stale
Copy link

stale bot commented Apr 1, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Apr 1, 2023
@aradi
Copy link
Member Author

aradi commented Apr 3, 2023

Still active, depends on centrally generated full neighbor lists.

@aradi aradi removed the stale label Apr 3, 2023
Copy link

stale bot commented Nov 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants