-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third order SCC stress components #139
Conversation
prog/dftb+/lib_dftb/thirdorder.F90
Outdated
real(dp) :: rab, tmp, tmp3(3), stTmp(3,3), prefac, vect(3) | ||
logical :: damping | ||
|
||
stTmp = 0.0_dp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stTmp(:,:) = 0.0_dp
if (iNeigh > this%nNeigh(iSp2, iAt1)) then | ||
cycle | ||
end if | ||
vect(:) = coords(:,iAt1) - coords(:,iAt2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering, whether we should refactor the part below it in a separate routine, as we call it here and also in the forceDC routine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly not until the XLBOMD and H5 changes are made compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, but we would need at least one test which checks it.
Missing term in the stress for DFTB3 in periodic boundaries added.