Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xyz writer optionally converts vector units #1426

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

bhourahine
Copy link
Member

Reverts the effect of ae1701a on the modes eigenvectors (which were being converted as though they were velocities).

@bhourahine bhourahine added the bug label Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 70.81%. Comparing base (84e04ec) to head (8c149a8).

Files Patch % Lines
src/dftbp/io/formatout.F90 56.25% 7 Missing ⚠️
app/modes/modes.F90 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
- Coverage   70.82%   70.81%   -0.01%     
==========================================
  Files         231      231              
  Lines       44110    44107       -3     
==========================================
- Hits        31239    31236       -3     
  Misses      12871    12871              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhourahine bhourahine added this to the 24.2 milestone Apr 9, 2024
@aradi aradi merged commit 8d6f08c into dftbplus:main Apr 9, 2024
4 of 7 checks passed
@bhourahine bhourahine deleted the xyzVectorUnits branch April 9, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants