Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nag issue with OpenMP in timedependent routines #6

Merged
merged 2 commits into from
Jun 12, 2017

Conversation

aradi
Copy link
Member

@aradi aradi commented Jun 12, 2017

No description provided.

@aradi aradi requested a review from bhourahine June 12, 2017 10:00
@aradi aradi changed the title Disable OMP for nagfor when compiling with td-dftb Fix nag issue with OpenMP in timedependent routines Jun 12, 2017
@aradi
Copy link
Member Author

aradi commented Jun 12, 2017

Got answer from NAG with proposed workaround (as in the last commit). This should be the best we can get without complex code modification.

Copy link
Member

@bhourahine bhourahine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@bhourahine bhourahine merged commit 7268adb into dftbplus:develop Jun 12, 2017
@aradi aradi deleted the fix-nag-omp-timedep branch June 13, 2017 06:31
bhourahine referenced this pull request in bhourahine/dftbplus Jun 10, 2019
Fix for API + transport trying to build
bhourahine added a commit that referenced this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants