Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility layer for integration with Vasp #113

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Jul 16, 2021

Add updated subdftd4.F and mocked Vasp modules to test compilation.

Closes #85
Closes dftd4/dftd4_vasp#3

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #113 (e0fd7c4) into main (e66e1e2) will decrease coverage by 0.87%.
The diff coverage is 0.00%.

❗ Current head e0fd7c4 differs from pull request most recent head 86e0239. Consider uploading reports for the commit 86e0239 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   60.04%   59.16%   -0.88%     
==========================================
  Files          39       40       +1     
  Lines        2903     2946      +43     
  Branches      985      995      +10     
==========================================
  Hits         1743     1743              
- Misses        599      642      +43     
  Partials      561      561              
Impacted Files Coverage Δ
src/dftd4/compat.f90 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66e1e2...86e0239. Read the comment docs.

@awvwgk awvwgk force-pushed the vasp branch 3 times, most recently from e170278 to 25dd5bf Compare July 16, 2021 13:28
@awvwgk awvwgk linked an issue Jul 16, 2021 that may be closed by this pull request
@awvwgk awvwgk linked an issue Jul 16, 2021 that may be closed by this pull request
@awvwgk awvwgk force-pushed the vasp branch 3 times, most recently from 38af825 to e0fd7c4 Compare July 16, 2021 13:56
@awvwgk awvwgk changed the title Add test for integration with Vasp Add compatibility layer for integration with Vasp Jul 16, 2021
@awvwgk awvwgk merged commit 282d547 into dftd4:main Jul 16, 2021
@awvwgk awvwgk deleted the vasp branch July 16, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant