Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace merge statements for optional parameters #202

Merged
merged 4 commits into from
May 14, 2023
Merged

Replace merge statements for optional parameters #202

merged 4 commits into from
May 14, 2023

Conversation

marvinfriede
Copy link
Member

Applying the suggestions from #201.

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #202 (fae6917) into main (bd278d4) will increase coverage by 0.05%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   42.81%   42.87%   +0.05%     
==========================================
  Files          31       31              
  Lines        2639     2652      +13     
  Branches     1095     1096       +1     
==========================================
+ Hits         1130     1137       +7     
- Misses        971      977       +6     
  Partials      538      538              
Impacted Files Coverage Δ
src/dftd4/param.f90 38.88% <43.75%> (+0.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/dftd4/param.f90 Outdated Show resolved Hide resolved
Co-authored-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
src/dftd4/param.f90 Outdated Show resolved Hide resolved
src/dftd4/param.f90 Outdated Show resolved Hide resolved
src/dftd4/param.f90 Outdated Show resolved Hide resolved
@marvinfriede marvinfriede requested a review from awvwgk May 14, 2023 09:05
@awvwgk awvwgk merged commit 75d502e into dftd4:main May 14, 2023
18 checks passed
@marvinfriede marvinfriede deleted the nag-fix branch May 14, 2023 12:23
@marvinfriede marvinfriede linked an issue May 14, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional argument used before checking present
3 participants