-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pairwise resolved dispersion energy calculation #82
Conversation
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 50.00% 55.87% +5.87%
==========================================
Files 36 37 +1
Lines 2514 2690 +176
Branches 870 928 +58
==========================================
+ Hits 1257 1503 +246
+ Misses 830 656 -174
- Partials 427 531 +104
Continue to review full report at Codecov.
|
This looks great, thank you! Do you have an opinion on which is easier: (a) add an alternate running mode for the dftd4 exe in QCEngine to harvest the json or (b) add pairwise analysis to the python interface here? I know I can do the former readily enough, but I won't if your plan is to have the python fully capable. |
I plan to keep the APIs on similar capabilities, meaning this feature will eventually be available in the |
Adds
--pair-resolved
option to command line interface to calculate pairwise resolved representation of energy. Pairwise energies are dumped as JSON if--json
flag is present.@loriab Is that what you were looking for?
Example output for the ammonia crystal
Closes #81