Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #76

Closed
dyve opened this issue Apr 3, 2018 · 3 comments
Closed

Cleanup #76

dyve opened this issue Apr 3, 2018 · 3 comments

Comments

@dyve
Copy link
Contributor

dyve commented Apr 3, 2018

We use this package @zostera, thanks for making this. Would a PR that does a little cleanup be welcome. I'd suggest:

  • get rid of nose (last release was over 2 years ago)
  • drop unsupported Python and Django combinations
  • fix deprecation warning where possible
@dfunckt
Copy link
Owner

dfunckt commented Apr 3, 2018 •
edited
Loading

@dyve yeah, it’d be great to have a PR for these. I guess dropping support for legacy django/python versions means a major version bump, which I’ve tried to delay in order to include a few other breaking changes, but I think we can go ahead.

@rpkilby rpkilby mentioned this issue Jun 25, 2018
Closed
@dfunckt
Copy link
Owner

dfunckt commented Jul 22, 2018

Fixed in rules 2.0 -- kudos @rpkilby

@dfunckt dfunckt closed this as completed Jul 22, 2018
@dyve
Copy link
Contributor Author

dyve commented Jul 23, 2018

Thx all, turned out I didn't have the time to take this one on, great to see these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dyve @dfunckt