Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable python syntax highlighting on README #11

Closed
wants to merge 3 commits into from

Conversation

jacobh
Copy link
Contributor

@jacobh jacobh commented Sep 16, 2014

note: Github isn't rendering the python syntax highlighting here, so this will only work once github fixes something on their end.

@dfunckt
Copy link
Owner

dfunckt commented Sep 16, 2014

Seems like the correct identifier for code-block is "pycon". See raw source of redis-py readme.

Thanks!

@jacobh
Copy link
Contributor Author

jacobh commented Sep 16, 2014

I think that's got it. let me know if you would like this to be rebased together

@dfunckt
Copy link
Owner

dfunckt commented Sep 16, 2014

Yes, that would be great, thanks.

@dfunckt
Copy link
Owner

dfunckt commented Sep 16, 2014

Apparently, pycon is for Python console code, python for plain Python code. Github seems to choke on html+django, so I removed it.

I have applied your commits to a temporary branch that I plan to merge to master later on, so no need to squash your commits.

@dfunckt
Copy link
Owner

dfunckt commented Sep 16, 2014

Merged in 8677cd3. Thanks!

@dfunckt dfunckt closed this Sep 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants