-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Python 2.6,3.3 & Django <1.8,1.9 #52
Conversation
Python 2.6 and 3.3 are no longer supported. Django <1.8 and 1.9 are no longer supported.
Hey @adamn, thanks for the PR! I see Travis complains about a missing import with pypy3/Django 1.10 -- any ideas why? |
s/missing import/import error |
Django 1.10+ doesnt support Python 3.2, upon which pypy3 is based. Since pypy3 is experimental there is not much point in testing it for Django 1.8 since thats an LTS release and there is probably nobody using pypy3/Django1.8
https://code.djangoproject.com/ticket/25849 is a wontfix so Django won't work on PyPy3. I've just removed it entirely since I can't imagine anybody will be using pypy3 with Django 1.8 and the next version of django-rules. It can be re-introduced whenever pypy3 supports Python 3.4+. |
I see, thanks for tracking this down. There are a few places rules branches depending on Django or Python version (eg. runtests.py, contrib/admin.py, README, etc.) -- are you willing to hunt them down and include their cleanup in this PR? They're already annotated so it should only be a matter of removing the back-compat branches. Otherwise looks good. |
Yeah I think I got all of them. Cheers. |
@@ -11,3 +11,5 @@ docs/_build | |||
pip-log.txt | |||
.tox | |||
.eggs/ | |||
.idea/ | |||
build/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty line is missing
I think that pypy3 can be restored. The issue was because TravisCI was using old version of PyPy3. Now it should be resolved. |
This is superseded by #82. Thank you! |
Python 2.6 and 3.3 are no longer supported. Django <1.8 and 1.9 are no longer supported.