Make Django2.0 compatible: use simple_tag, closes #69 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
I don't quite see how the occurring pypy errors (occurring only with pypy between Django 1.5 and 1.7) can be this PR's fault, but if you point me in the right direction, I'll gladly tackle them. |
|
@rixx Django 1.5-1.7 are all no longer supported, and were never supported by Django project with python version 3.5 (which this pypy3 is equivalent to). Personally, I think these test environments should just be removed. |
|
Sounds plausible enough. @dfunckt, what do you think –could you merge this PR and provide a patch release? |
Closed
|
d2a8831 adds Django 2.0 support. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the previous discussion on #65, and while I agree that dropping versions and other major changes should have to wait, I'm anxious to move to Django 2.0, and as long as this involves only a few corrected imports, I'd be really happy if you'd decide to merge this PR and make a patch release.