Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Will only accept oracle interfaces and not just any addresses #55

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Will only accept oracle interfaces and not just any addresses #55

merged 3 commits into from
Sep 30, 2022

Conversation

chanharryhk
Copy link
Contributor

@chanharryhk chanharryhk commented Sep 19, 2022 •
edited
Loading

Description

newAssimilator oracle param now conforms to IOracle interface fixes #43

Integrations Checklist

  • Have any function signatures changed? If yes, outline below.
  • Have any features changed or been added? If yes, outline below.
  • Have any events changed or been added? If yes, outline below.
  • Has all documentation been updated?

Changelog

Function Signature Changes

Features

Events

@tommy4241 tommy4241 self-requested a review September 26, 2022 17:50
@chanharryhk chanharryhk mentioned this pull request Sep 27, 2022
Closed
15 tasks
tommy4241
tommy4241 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@tommy4241 tommy4241 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good 👍

@chanharryhk chanharryhk reopened this Sep 30, 2022
@chanharryhk chanharryhk changed the base branch from main to audit/combinedV2 September 30, 2022 17:16
@chanharryhk chanharryhk merged commit cf653a5 into audit/combinedV2 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommy4241 tommy4241 tommy4241 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.2
2 participants
@chanharryhk @tommy4241