Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add isNotEmergency modifier, add this to withdraw and deposit #64

Merged
merged 3 commits into from
Sep 30, 2022
Merged

add isNotEmergency modifier, add this to withdraw and deposit #64

merged 3 commits into from
Sep 30, 2022

Conversation

tommy4241
Copy link
Contributor

@tommy4241 tommy4241 commented Sep 26, 2022 •
edited by chanharryhk
Loading

Changelog

Fixes #40
Added isNotEmergency modifier

chanharryhk
chanharryhk suggested changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@chanharryhk chanharryhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Flash should also have this modifier and shouldnt transferFrom, transfer, depositWithWhitelist, targetSwap, originSwap all have it? Better safe than sorry.

@chanharryhk chanharryhk mentioned this pull request Sep 27, 2022
Closed
15 tasks
@chanharryhk chanharryhk self-requested a review September 28, 2022 15:19
chanharryhk
chanharryhk approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@chanharryhk chanharryhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chanharryhk chanharryhk changed the base branch from main to audit/combined September 30, 2022 15:57
@chanharryhk chanharryhk merged commit 544b7ee into audit/combined Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanharryhk chanharryhk chanharryhk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.4
2 participants
@tommy4241 @chanharryhk