Detecting event source without filesystem check

dg · Nov 7, 2022 · 93e84bc · 93e84bc
1 parent 1585255
commit 93e84bc
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/Dibi/Event.php b/src/Dibi/Event.php
@@ -63,7 +63,11 @@ public function __construct(Connection $connection, int $type, ?string $sql = nu
 
 		$dibiDir = dirname((new \ReflectionClass('dibi'))->getFileName()) . DIRECTORY_SEPARATOR;
 		foreach (debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS) as $row) {
-			if (isset($row['file']) && is_file($row['file']) && !str_starts_with($row['file'], $dibiDir)) {
+			if (
+				isset($row['file'])
+				&& !str_starts_with($row['file'], $dibiDir)
+				&& !str_ends_with($row['file'], ": eval()'d code")
+			) {
 				$this->source = [$row['file'], (int) $row['line']];
 				break;
 			}

diff --git a/tests/dibi/Event.source.phpt b/tests/dibi/Event.source.phpt
@@ -0,0 +1,24 @@
+<?php
+
+/**
+ * @dataProvider ../databases.ini
+ */
+
+declare(strict_types=1);
+
+use Tester\Assert;
+
+require __DIR__ . '/bootstrap.php';
+
+$conn = new Dibi\Connection($config);
+
+$event = new Dibi\Event($conn, Dibi\Event::CONNECT);
+Assert::same([__FILE__, __LINE__ - 1], $event->source);
+
+eval('$event = new Dibi\Event($conn, Dibi\Event::CONNECT);');
+Assert::same([__FILE__, __LINE__ - 1], $event->source);
+
+array_map(function () use ($conn) {
+	$event = new Dibi\Event($conn, Dibi\Event::CONNECT);
+	Assert::same([__FILE__, __LINE__ - 1], $event->source);
+}, [null]);