Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility modifier of function Dibi\Connection::translateArgs() #237

Closed
chvilalukas opened this issue Sep 8, 2016 · 2 comments
Closed

Comments

@chvilalukas
Copy link

Please change visibility modifier of function Dibi\Connection::translateArgs() and variable $this->translator in the same class to protected. We need to create custom modification of translator and without this modification it is not possible. Thank you.

Sorry for my English...

@JanTvrdik
Copy link
Sponsor Contributor

Could you elaborate on what you intend to change?

@chvilalukas
Copy link
Author

Currently we use dibi, which we in the class “Translator” have added modifier %mm (engineered variant of modifier %m). But at the same time we want to use “Composer”, so customizing the class is not an option.
When I look into class code of “Translator”, it should not be a problem to write a class inheriting from classes “Translator” and help her supply that modifier. The problem is that in the class “Connection” is not how the class inheriting from “Translator” pass. Maybe instead of editing of the visibility It would be enough to add functionality with which it would be possible to set a different translator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants