Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nette 3.0 Bridge + Tracy Panel #296

Closed
elcheco opened this issue Jun 14, 2018 · 5 comments
Closed

Nette 3.0 Bridge + Tracy Panel #296

elcheco opened this issue Jun 14, 2018 · 5 comments

Comments

@elcheco
Copy link
Contributor

elcheco commented Jun 14, 2018

There's an incompatibility in latest Dibi 4.0 causing BC break on $container->setClass() which should be changed to 'setFactory' in Nette 3.0 in the class DibiExtension22

I did a fork for myself and created DibiExtension30 and changed it there to setFactory and everything is working again.

You can see the changes here:
elcheco/dibi-nette30@0c9f61d

But because it's early phase of Nette 3.0 and I decided on a project which will go live in a couple of months to use already Nette 3.0 - so I solved it for now by this little hack and changing composer.json repository settings to mine, but I can imagine you'll see some better solution for that maybe and that's why I am not going the pull request way...

@dg
Copy link
Owner

dg commented Jun 14, 2018

setFactory should work in Nette 2.2, so I think it can be simply fixed in DibiExtension22

@elcheco
Copy link
Contributor Author

elcheco commented Jun 14, 2018

Ok. Shall I do the PR for you then or you will do it on master? 😄

@elcheco
Copy link
Contributor Author

elcheco commented Jun 14, 2018

As I am having 2.4 and 3.0 - in 2.4 DI it worked, but in 3.0 it strictly said - just factory is allowed, so that why for now I went this way, I just wanted to report it...

@dg
Copy link
Owner

dg commented Jun 14, 2018

PR for master would be fine

@elcheco
Copy link
Contributor Author

elcheco commented Jun 14, 2018

Will do 👍

@dg dg closed this as completed Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants