Skip to content

Commit

Permalink
Remove service labeling temporarily
Browse files Browse the repository at this point in the history
Fixes GoogleContainerTools#959

Signed-off-by: David Gageot <david@gageot.net>
  • Loading branch information
dgageot committed Sep 12, 2018
1 parent 24aefd2 commit bd39ddc
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions pkg/skaffold/deploy/labels.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"encoding/json"
"fmt"
"io"
"strings"
"time"

"github.com/GoogleContainerTools/skaffold/pkg/skaffold/build"
Expand Down Expand Up @@ -140,6 +141,13 @@ func updateRuntimeObject(client dynamic.Interface, disco discovery.DiscoveryInte
return errors.Wrap(err, "getting metadata accessor")
}
name := accessor.GetName()

kind := modifiedObj.GetObjectKind().GroupVersionKind().Kind
if strings.EqualFold(kind, "Service") {
logrus.Debugf("Labels are not applied to service [%s] because of issue: https://github.com/GoogleContainerTools/skaffold/issues/887", name)
return nil
}

namespace := res.Namespace
addLabels(labels, accessor)

Expand Down

0 comments on commit bd39ddc

Please sign in to comment.