Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamlitonian Sampling for Balmer Lines #22

Open
5 tasks
dgahle opened this issue Sep 8, 2023 · 1 comment
Open
5 tasks

Hamlitonian Sampling for Balmer Lines #22

dgahle opened this issue Sep 8, 2023 · 1 comment
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Comments

@dgahle
Copy link
Owner

dgahle commented Sep 8, 2023

Update BaySAR to be compatible with inference.mcmc.HamiltonianChain to resolve the effective sample size in demo/balmer_series.py` flatlining at about 7.

Useful links:

Task list

  • Write out the mathematics
  • Plan out the objects that require a gradient class method
  • Update this list with the above and cross out as going along
  • Add unit tests to verify functionality
  • Update demo/balmer_series.py with the HamiltonianChain
@dgahle dgahle added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Sep 8, 2023
@dgahle dgahle added this to the Intial pre-release (v0.0) milestone Sep 8, 2023
@dgahle dgahle self-assigned this Sep 8, 2023
@dgahle
Copy link
Owner Author

dgahle commented Sep 9, 2023

It's likely that each function that needs to be differentiated will need to be a class that can store all the dependent/nested function gradient methods can be accessed for.

Or cache the gradients of some of the lowest level functions like emission, temperature, and density profiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant