Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start of a Balmer Series BaySAR demo. #19

Merged
merged 27 commits into from
Sep 8, 2023
Merged

Start of a Balmer Series BaySAR demo. #19

merged 27 commits into from
Sep 8, 2023

Conversation

dgahle
Copy link
Owner

@dgahle dgahle commented Jul 2, 2023

No description provided.

@dgahle dgahle added the enhancement New feature or request label Jul 2, 2023
@dgahle dgahle self-assigned this Jul 2, 2023
@dgahle dgahle linked an issue Jul 2, 2023 that may be closed by this pull request
Fix demo #10
Closed
2 tasks
@dgahle
Added inference-tools to requirements.txt
874e25a
@dgahle
Balmer Series demo running but unstable.
88e0fbd
@dgahle
Corrected species registering in the input functions.
175be04
@dgahle
Correct float check for updated numpy version.
889e7be
@dgahle
Replaced adas with internal functions.
15d01a0
@dgahle
Replaced adas with internal routines.
18b6f9c
@dgahle
Updated for newr scipy version and use of DataArrays.
c48fd13
@dgahle
Added num parameters to MeshLine.
6205083
@dgahle
Replaced jit(nopython) decorator for njit.
0a044e0
@dgahle
Updated plotting fonts.
3a17153
@dgahle
Removed njit from solve_rate_matrix ans it broke the function.
33efd69
@dgahle
Config for the zero fit in the demo script.
db0c6b9
@dgahle
Moved hard coded variables to a config, added self vs self fit, compl…
3b98b5c 
…eted zero fit, and added optimsation graphics.
@dgahle
Removed deprecated normal font from passed matplotlib.plot config.
eb52a1f
@dgahle
Added nan check to theta bounds. This can be introduced by the estima…
c8a9d74 
…tion of the bounds. Typically the background parameter.
@dgahle
Corrected interpolation and type errors on DataArray.interp use.
0f7ce7a
@dgahle
Added types and dimesntion checking and formatting into within function.
d72923e
@dgahle
Added input formatting to make_input_dict function.
a0f7dc1
@dgahle
Balmer series demo optimisaed but doesn't sample well.
39dc97d
@dgahle
Added no_sample_neutrals to demo/zero_fit_config.json
a94fde8
@dgahle
Correct NaN and type errors in use of DataArray.interp method.
7bd117a
@dgahle
Files to run demo/balmer_series.py in a docker container.
9c7d246
@dgahle
Added line break to aid reading.
6797951
@dgahle
Finished writing the docker image file to run demo/balmer_series.py. …
0d06dab 
…Runs succesfully.
@dgahle
Updated image to use more internal commands and reduce use of ADD fun…
6af3f31 
…ction.
@dgahle
Python scripts formatted with black and isort.
9027845
@dgahle
Copy link
Owner Author

dgahle commented Sep 8, 2023

Result of self vs self fit.

                       Target        Fit      Diff

background_0 11.997506 11.975207 -0.022299
electron_density#0 13.903090 13.678650 -0.224440
electron_density#1 0.000000 0.247329 0.247329
electron_density#2 3.000000 5.649743 2.649743
electron_temperature#0 0.698970 0.593455 -0.105515
electron_temperature#1 3.000000 3.531062 0.531062
electron_temperature#2 1.000000 2.001631 1.001631
H_0_dens 13.903090 14.120223 0.217133
H_0_tau -8.000000 -5.727586 2.272414
H_0_velocity 0.000000 -0.623301 -0.623301

Difficulties with optimisation will be tackled by issue #22

@dgahle dgahle merged commit 60addae into main Sep 8, 2023
1 of 2 checks passed
@dgahle dgahle deleted the balmer-demo branch September 8, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dgahle dgahle

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix demo
1 participant
@dgahle