Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Total tests count is different from other reporters #23

Closed
idiotWu opened this issue Jan 4, 2017 · 3 comments
Closed

Total tests count is different from other reporters #23

idiotWu opened this issue Jan 4, 2017 · 3 comments

Comments

@idiotWu
Copy link
Contributor

idiotWu commented Jan 4, 2017

When I run tests in multiple browsers, it seems nyan reporter will only count total tests from one test suite:

wx20170104-150939

wx20170104-150956

Notice that the total count and passed count stay the same. And if I use the mocha-reporter, I will actually get a total count at 64:

wx20170104-151149
@idiotWu
Copy link
Contributor Author

idiotWu commented Jan 4, 2017

I got a solution to this issue, a PR will be sent soon 😺

idiotWu added a commit to idiotWu/karma-nyan-reporter that referenced this issue Jan 4, 2017
@idiotWu
fix: sum up all tests stats
9882e12 
resolve dgarlitt#23
@idiotWu idiotWu mentioned this issue Jan 4, 2017
Merged
@dgarlitt
Copy link
Owner

dgarlitt commented Jan 5, 2017 •
edited
Loading

@idiotWu Thanks for the PR, looks good. Will merge and create a release.

@dgarlitt
Copy link
Owner

dgarlitt commented Jan 5, 2017

@idiotWu Your changes have been merged and published to npm in the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgarlitt @idiotWu