Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idk, i like dispatching, this should be tested, rusty on flask #106

Closed
wants to merge 2 commits into from
Closed

idk, i like dispatching, this should be tested, rusty on flask #106

wants to merge 2 commits into from

Conversation

ivanbelenky
Copy link
Contributor

@ivanbelenky ivanbelenky commented Apr 5, 2024 •
edited by dgarnitz

What

Move validation logic into its own service

@dgarnitz
Copy link
Owner

dgarnitz commented Apr 5, 2024

@ivanbelenky this is awesome! Did you run the code locally to ensure it works? If not I can pull it down to test that it runs

@dgarnitz dgarnitz self-assigned this Apr 5, 2024
@dgarnitz dgarnitz self-requested a review April 5, 2024 17:18
dgarnitz
dgarnitz requested changes Apr 5, 2024
View reviewed changes
Copy link
Owner

@dgarnitz dgarnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work but the tests don't pass. Take a look at this PR here I made - #107 - this fixes them

It also removes some unnecessary code from the API that doesn't need validation anymore

@dgarnitz
Copy link
Owner

dgarnitz commented Apr 5, 2024

Gonna close this since the other branch fixed it

@dgarnitz dgarnitz closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgarnitz dgarnitz dgarnitz requested changes

Assignees

@dgarnitz dgarnitz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivanbelenky @dgarnitz