-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more custom dp scores for faster contractions #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Can we add a few notes on the DP optimizer's new minimizers in the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once mypy is worked through. Let me know if you would like a hand!
Description
This adds more custom functions to the dp solver as outlined in #171. For example:
should give better real world performance in many cases than the pure minimized flop cost alone.
Also included is a couple of 'micro' optimizations for the path finders performance - namely, making some inner loop calls functions not methods.
Todos
Questions
I tried the black formatter and it showed lots of changes across many files - currently have just committed those on the files modified...? Am I invoking it wrong? (edit: might just be that the condablack
is a bit out-of-date)Status