Improvements, adding RTM option in bot options #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seriouslysean
commented
Dec 5, 2018
| var env_file = __dirname + '/.env'; | ||
| const fs = require('fs'); | ||
| const env = require('node-env-file'); | ||
| const env_file = __dirname + '/.env'; |
There was a problem hiding this comment.
Converted a lot of the vars to consts for security.
bot.js
Outdated
| clientId: process.env.clientId, | ||
| clientSecret: process.env.clientSecret, | ||
| clientSigningSecret: process.env.clientSigningSecret, | ||
| // debug: true, | ||
| scopes: ['bot'], | ||
| studio_token: process.env.studio_token, | ||
| studio_command_uri: process.env.studio_command_uri | ||
| studio_command_uri: process.env.studio_command_uri, | ||
| require_delivery: true, // required for RTM (Real Time Messaging) support |
There was a problem hiding this comment.
This is required if we ever use RTM, it makes sure a message is delivered before the bot actions on it and ensures things happen in order.
|
|
||
| // Load in some helpers that make running Botkit on Glitch.com better |
There was a problem hiding this comment.
Removed all the Glitch.com stuff we'll never use.
| protocol: req.protocol, | ||
| glitch_domain: process.env.PROJECT_DOMAIN, | ||
| layout: 'layouts/default' | ||
| webserver.get('/', (req, res) => { |
There was a problem hiding this comment.
If we have a clientId and clientSecret, just show the install page.
|
|
||
| webserver.get('/', (req, res) => { |
There was a problem hiding this comment.
If we don't have a clientId or clientSecret, just show a very basic message.
dgautsch
reviewed
Dec 5, 2018
bot.js
Outdated
|
|
||
| var bot_options = { | ||
| const bot_options = { | ||
| clientId: process.env.clientId, | ||
| clientSecret: process.env.clientSecret, | ||
| clientSigningSecret: process.env.clientSigningSecret, | ||
| // debug: true, | ||
| scopes: ['bot'], | ||
| studio_token: process.env.studio_token, |
There was a problem hiding this comment.
remove studio tokens since we aren't going to use that
dgautsch
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various cleanup and some RTM (Real Time Messaging) requirements. Comments inline!