Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ketchup status changes #42

Merged
merged 2 commits into from
Aug 4, 2022
Merged

ketchup status changes #42

merged 2 commits into from
Aug 4, 2022

Conversation

PeterKraus
Copy link
Contributor

@PeterKraus PeterKraus commented Aug 3, 2022

This PR closes #32:

  • ketchup status <jobid> accepts multiple jobids both as a comma- or space-separated list
  • ketchup status <jobid> returns a yaml list of job info
  • ketchup submit <jobfile> returns a single yaml job info
  • ketchup search <jobname> returns a yaml list of job info

@PeterKraus
Copy link
Contributor Author

@lorisercole Please have a look and let me know what you think. I don't think I want to implement ketchup status queue -a, as you can already list all jobs (including completed) using the verbose switch: ketchup status queue -v. Although neither ketchup status state nor ketchup status queue will print a yaml-formatted output.

@PeterKraus PeterKraus added this to the 0.2 milestone Aug 3, 2022
@lorisercole
Copy link
Contributor

Thanks @PeterKraus! I tried it out, it looks nice!

I just noticed one thing, that is not related to this PR though:
If I submit an old version payload (0.1), I get this:

WARNING:dgbowl_schemas.tomato:Could not parse 'kwargs' using Payload v0.2.
WARNING:dgbowl_schemas.tomato:1 validation error for Payload
version
  unexpected value; permitted: '0.2' (type=value_error.const; given=0.1; permitted=('0.2',))
jobid: 29
jobname: null

Is that expected?

@PeterKraus
Copy link
Contributor Author

It's expected, as ideally you'd want folks to use the newest version of the payload, but I should perhaps drop it from a WARNING to INFO. I've made an issue over on the other repo: dgbowl/dgbowl-schemas#13

@PeterKraus
Copy link
Contributor Author

@lorisercole: I'll merge this after our test today.

@lorisercole
Copy link
Contributor

lorisercole commented Aug 15, 2022

Hey @PeterKraus,
could you possibly add a tag to this new version of the code (e.g. 0.2a2)?
I'll refer to it in aiida-aurora: I have just updated the scheduler module to parse the new format.
Thanks

lorisercole added a commit to EmpaEconversion/aiida-aurora that referenced this pull request Aug 15, 2022
Solves #3
This new version of the scheduler can read and parse the new format of
the tomato scheduler (`0.2a2`, see dgbowl/tomato#42).
@PeterKraus
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ketchup status: multiple jobids and format
2 participants