Incorrect allocation by ratios

[itd3v]

Hi!
That is a cool library, thanks for your time to develop it and make others life easier:)

While integrating it into my project I've found wrong allocation using ratios:
10m.Usd().Allocate(new RatioCollection(1m, 0m));
Expected result: 10m & 0m
Act result: 10.01m & -0.01m
NMoneys version: 6.1.0

Seems the problem is in Currency.Round method in MidpointRounding value.

internal decimal Round(decimal share)
{
	decimal raw = share - (.5m * MinAmount);
	decimal rounded = Math.Round(raw, SignificantDecimalDigits, MidpointRounding.AwayFromZero);
	return rounded;
}

Thanks in advance.

[itd3v]

I've made a pull request, please check it when it possible.
Thanks.

[dgg]

Hi,

Thanks for the compliment.
I will be able to have a look at it this evening.
I'll have to build myself a .NET dev environment and check that the release process still works.

Thanks a lot for the contribution

[dgg]

Hi I was able to have a look.
Oh boy this project is old! Besides, I do not have a Windows machine anymore and that makes things twice as difficult.

I could verify the changes look good but the "automated" release process cannot run as it is pretty ancient.
I cannot release manually due to lack of time today, but I will try my luck tomorrow.

Thanks for the contribution.
I promise I will push the changes as soon as possible.

[itd3v]

Hi Daniel!
Thanks a lot, I appreciate your efforts.
Will wait;)

Have a good time!

[itd3v]

Hi Daniel!
Hope are doing good.

Any update?

[dgg]

Hi,

Good news.

CI was able to build the project and I could manually push it to the gallery: https://www.nuget.org/packages/NMoneys/6.1.1

I will be creating the rest of the release artifacts later today.

Thanks for the contribution