-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect allocation by ratios #55
Comments
I've made a pull request, please check it when it possible. |
Hi, Thanks for the compliment. Thanks a lot for the contribution |
Hi I was able to have a look. I could verify the changes look good but the "automated" release process cannot run as it is pretty ancient. Thanks for the contribution. |
Hi Daniel! Have a good time! |
Hi Daniel! Any update? |
Hi, Good news. CI was able to build the project and I could manually push it to the gallery: https://www.nuget.org/packages/NMoneys/6.1.1 I will be creating the rest of the release artifacts later today. Thanks for the contribution |
Hi!
That is a cool library, thanks for your time to develop it and make others life easier:)
While integrating it into my project I've found wrong allocation using ratios:
10m.Usd().Allocate(new RatioCollection(1m, 0m));
Expected result: 10m & 0m
Act result: 10.01m & -0.01m
NMoneys version: 6.1.0
Seems the problem is in
Currency.Round
method inMidpointRounding
value.Thanks in advance.
The text was updated successfully, but these errors were encountered: