This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
Amend oembed param url tags for hide_thread and omit_script #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskingnet
changed the title
dghubble
force-pushed
the
amend-oembed-url-tags
branch
from
5e22a5d
to
fa59658
Compare
|
Thanks, but the project is being deprecated #207 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL tags present on the StatusOEmbedParams struct for the HideThread and OmitScript field were both hide_media which results in unexpected behaviour when trying to use these options.
With this PR I have set these to the correct URL tags, as outlined here: https://developer.twitter.com/en/docs/twitter-for-websites/timelines/guides/oembed-api.
Thanks for your work and effort in maintaining this client!