Add Doer interface and setter #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Sling is an HTTP Request builder and sender. | ||
| type Sling struct { | ||
| // http Client for doing requests | ||
| httpClient *http.Client | ||
| doer Doer |
There was a problem hiding this comment.
let's just keep the unexported variable called httpClient or client since that still reflects its purpose when reading through
|
Thanks! Can you split out the indent feature into a separate PR and remove the merge commit please? |
address #15
|
Sorry, I meant to clean up the history. Not sure how that merge commit crept in there. This PR now just contains the doer change. |
|
There are some comments on the outdated diffs as well. |
|
I didn't understand the comment "apply this change in the previous commit". Maybe this doesn't apply since the commit history was revised? |
|
Squashed and merged as 4b482f9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced use of *http.Client with interface Doer. Allows use of client-side middleware by wrapping *http.Client before passing to Sling.