Introduce response decoder interface #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dghubble would it be possible to get feedback on the PR, it would be a very useful feature in my case. Thanks! :-) Just noticed the build is failing for G 1.8, need to look into that. |
dghubble
reviewed
Nov 18, 2018
maxbeutel
force-pushed
the
response-decoder
branch
from
43474e4
to
5ce5b3a
Compare
maxbeutel
force-pushed
the
response-decoder
branch
from
5ce5b3a
to
6d06265
Compare
|
Thanks for the feedback and corrections! I updated the PR & rebased. |
|
i bet this would come in handy ;) #47 |
|
@dghubble friendly bump :-) good to merge now? |
dghubble
approved these changes
Nov 25, 2018
|
@dghubble may I ask to create a new release including above changes? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use Sling to get data from JSON APIs, soon I will have the use case to receive data from XML APIs, too. Hence I suggest a way that allows decoding responses from arbitrary sources:
ResponseDecoderinterface that abstracts away the actual decodingjsonDecoderthat does what the library is doing at the moment: decoding from JSON (keep bc)Is there a chance of getting this merged?