Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for callable __table_args__ and __local_table_args__. #13

Merged
merged 1 commit into from
Jan 20, 2015

Conversation

seth-p
Copy link
Contributor

@seth-p seth-p commented Jan 17, 2015

No description provided.

@seth-p seth-p force-pushed the callable_declarative_args branch 6 times, most recently from bb38eea to e08f8f9 Compare January 17, 2015 22:04
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e08f8f9 on seth-p:callable_declarative_args into 8d525da on dgilland:develop.

@seth-p
Copy link
Contributor Author

seth-p commented Jan 17, 2015

Afraid I can't figure out why the 2.6 test failed: https://travis-ci.org/dgilland/alchy/jobs/47381387.
The 2.7, 3.3, and 3.4 tests passed: https://travis-ci.org/dgilland/alchy/builds/47381386.

@dgilland
Copy link
Owner

Looks like a Python 2.6 regression in astroid which is required by pylint: https://travis-ci.org/dgilland/alchy/jobs/47381387#L500 (line 500)

Seems astroid was updated on 1/16/15: https://pypi.python.org/pypi/astroid/1.3.4

The issue is this line in astroid.modutils: https://bitbucket.org/logilab/astroid/src/bbeb96a16e25b2ac106f38eb830026de9a1be8b0/astroid/modutils.py?at=default#cl-69

The syntax used is not compatible with Python 2.6. It's also the same kind of syntax that caused alchy to fail on Travis with Python 2.6 due to the version of pylint being used at the time.

The easiest fix for this would be to pin astroid to a previous version. Version 1.3.2 may work. It was released 11/22/2014 and it's version of modutils doesn't contain the Python 2.6 syntax issue.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d713438 on seth-p:callable_declarative_args into 8d525da on dgilland:develop.

@seth-p
Copy link
Contributor Author

seth-p commented Jan 18, 2015

Added "astroid<=1.3.2" to requirements.txt, which fixed the Python 2.6 problem.

@dgilland
Copy link
Owner

Thanks!

dgilland added a commit that referenced this pull request Jan 20, 2015
Add support for callable __table_args__ and __local_table_args__.
@dgilland dgilland merged commit 45a5607 into dgilland:develop Jan 20, 2015
@seth-p seth-p deleted the callable_declarative_args branch March 20, 2015 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants