Replace __local_mapper/table_args__ with __merge_mapper/table_args__. #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at fixing the logic for merging
__mapper/table_args__
from base classes.In the absence of callables, the logic for setting
cls.__mapper/table_args__
is straightforward:cls.__dict__
specifies'__mapper/table_args__'
, then simply use that;cls.__dict__['__merge_mapper/table_args__']
(if any) with the recursive calculation of__mapper/table_args__
for every basebase in cls.__bases__
.In the case that any of the base
__mapper/table_args__
are constructed from callables (e.g. classmethods), such callables are reevaluated forcls
.