Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some bugs in should_set_tablename. #22

Merged
merged 1 commit into from
Apr 24, 2015
Merged

Fixed some bugs in should_set_tablename. #22

merged 1 commit into from
Apr 24, 2015

Conversation

seth-p
Copy link
Contributor

@seth-p seth-p commented Apr 24, 2015

This PR fixes the following problems:

  1. A __tablename__ should not be set for a class that inherits from AbstractConcreteBase and sets a primary key.
  2. The logic for determining whether a class has a primary key should ignore a column with a primary key is defined in a base class if it is overridden (in the mro) by a column of the same name without a primary key.

@seth-p seth-p force-pushed the should_set_tablename_fixes branch 2 times, most recently from 60355ef to a87e4c7 Compare April 24, 2015 14:16
@seth-p seth-p changed the title Fixed should_set_tablename. Fixed some bugs in should_set_tablename. Apr 24, 2015
@seth-p seth-p force-pushed the should_set_tablename_fixes branch 4 times, most recently from 2caf4fe to ff3807e Compare April 24, 2015 19:45
@seth-p seth-p force-pushed the should_set_tablename_fixes branch from ff3807e to ccbcc46 Compare April 24, 2015 20:20
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ccbcc46 on seth-p:should_set_tablename_fixes into 7883dcb on dgilland:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ccbcc46 on seth-p:should_set_tablename_fixes into 7883dcb on dgilland:develop.

dgilland added a commit that referenced this pull request Apr 24, 2015
@dgilland
Merge pull request #22 from seth-p/should_set_tablename_fixes
fba26a6 
Fixed some bugs in should_set_tablename.
@dgilland dgilland merged commit fba26a6 into dgilland:develop Apr 24, 2015
@seth-p seth-p deleted the should_set_tablename_fixes branch April 24, 2015 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seth-p @coveralls @dgilland