Implemented late initialisation for the Manager #31
Conversation
Passes tests, and works as expected.
| # declaration (i.e: Manager()) then init it | ||
| # otherwise, it's a late bind. | ||
| if config is not None or session_options is not None \ | ||
| or Model is not None or session_class is not None: |
There was a problem hiding this comment.
I would say that we probably only want to look at config to determine if setup should proceed. While Model will typically be passed in, having Model=None is a supported use-case. The other arguments, session_options and session_class both have sane defaults and may not be provided.
|
I'm fine with including this functionality (after code comments addressed). However, we may want to consider throwing an exception in The only other downside I see if the use-case where no I will probably also include late-binding configuration in alchy's successor sqlservice. Development on alchy has mostly gone into maintenance-mode while development on sqlservice is moving along (although slowly). |
|
Right on man! Didn't even realise you had another project in the works; I'll take a look at it when I get a chance. As for the changes mentioned, I can do that without a problem. When I get some time in the next day or so, maybe tonight (depends on if I meet my project goals) I can take it on. Thanks for the feedback, and for the great project! |
|
Closing due to inactivity. Feel free to resubmit if you have time to wrap it up. |
I stumbled across Alchy after having used SqlAlchemy with Flask-Sqlalchemy and wanted something similar for a non-flask project through work.
The only issue I found, was having a 'late-bind' sort of feature, where in Flask-Sqlalchemy there is the 'init_app()' method.
This is my take on that approach, in a much more straightforward, and direct approach.
It changes nothing under the hood, and assuming it's used responsibly it's a painless feature.
If there's anything I can do to improve this, or further solidify it then please let me know!