Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizing __init__.py #9

Merged
merged 1 commit into from
Jul 26, 2014
Merged

Conversation

nathancahill
Copy link
Contributor

Looking at the potentially huge __init__.py once pydash fully implements Lodash.. what do you think about giving each section it's own file? See branch here: https://github.com/nathancahill/pydash/tree/reorganize/pydash

@dgilland
Copy link
Owner

That's essentially what I was planning to do. Feel free to submit a pull request for it.

Good job! 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 187ba07 on nathancahill:reorganize into c1ffc04 on dgilland:master.

dgilland added a commit that referenced this pull request Jul 26, 2014
@dgilland dgilland merged commit 5edf22a into dgilland:master Jul 26, 2014
@nathancahill
Copy link
Contributor Author

Used a little import ugliness to prevent circular imports.. any ideas on the best way to fix this?

uniq() in arrays.py imports collection.where()
at() in collections.py imports arrays.flatten()
_make_callback() in utils.py imports collection.pluck() and collection.where()

@nathancahill nathancahill deleted the reorganize branch July 26, 2014 15:54
@dgilland
Copy link
Owner

I'm looking into that now.

@dgilland
Copy link
Owner

I've moved the circular import issue to #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants