Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 ci(workflow): Update workflow triggers and remove failed workflow #675

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

h7ml
Copy link
Contributor

@h7ml h7ml commented Apr 14, 2024

Fixes

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/dgiot/dgiot/blob/master/CONTRIBUTING.md.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

  • Changed the workflow at https://github.com/dgiot/dgiot/blob/master/.github/workflows/gitee-repos-mirror.yml to be manually triggered, as the owner @h7ml of the dst_key and dst_token has left the organization and repository, resulting in a lack of permissions for these keys.
  • Left the organization, and receiving failure emails from the workflow daily, causing unwanted spam emails.
  • Suggested changing the values of the private key and token fields to be managed by the repository and organization admins.

Details can be found in the documentation at https://github.com/Yikun/hub-mirror-action.

Mainly for workflow organization:

  • Adjusted trigger mode to manual for .github/workflows/gitee-repos-mirror.yml and .github/workflows/label.yml.
  • Removed .github/workflows/build_slim_packages.yaml due to continuous failures in build_slim_packages.

@h7ml h7ml changed the title 👷 ci(gitee-repos-mirror): Update workflow to be manually triggered 👷 ci(workflow): Update workflow triggers and remove failed workflow Apr 14, 2024
@dawnwinterLiu dawnwinterLiu merged commit 9ed47f6 into dgiot:master Apr 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants