Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve the order the option were defined in the generated doc #7

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

meztez
Copy link
Contributor

@meztez meztez commented Nov 28, 2023

This is an attempt. Don't know if the same behavior happens for other users.

names(optenv) does not seems to return the names in the same order as they were defined with successive define_option. I wonder if using names(details) can work instead, wonder why it wasn't used in the first place?

Anyway.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9224795) 89.34% compared to head (e29d24f) 89.34%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files          10       10           
  Lines         413      413           
=======================================
  Hits          369      369           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgkf
Copy link
Owner

dgkf commented Nov 28, 2023

Thanks for another awesome find @meztez. I took the liberty of adding some unit tests - hope you don't mind.

@dgkf dgkf merged commit a2c1102 into dgkf:main Nov 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants