Yves/fix for perl 5 37 8 #10
Conversation
|
I am confused. rt redirects to the issues page for this project, but there isn't one. Doesn't matter much for me as I have a PR anyway, but its a bit weird, threw me off. Also for some reason metacpan doesnt contain a link to here for "repository" but it does for bug reports. Very confusing. |
|
Thanks, I think there's some old metadata around, I've tried to fix that, this is the correct repo! As far as I can tell the syncronize commit is just reverting 1cae52d -- I bumped the minimum perl version on CPAN to see if anyone complained (they didn't), but the next commit just removed the compat code ready for the next release. So it should be safe to just revert that and release this, thanks! |
|
Feel free to drop that patch. Or I can repush. Up to you. I wasnt sure what was going on so it is entirely possible I got things upside down. Let me know if I should repush. |
We reworked branch reset and added logical_nparens. This passes test with 5.37.8 and later
demerphq
force-pushed
the
yves/fix_for_perl_5_37_8
branch
from
6ca8d30
to
4551417
Compare
|
I dropped the patch. No sense in cluttering up your changelog with unnecessary reverts. Thanks for the fast feedback! |
|
BTW, I may be making more significant changes in the future, but it would help me clear up my present BBC backlog if you could release with this first. Sorry for the extra work. :-( [On the other hand, if I have my way the new way of doing things should be faster, at least in core] |
|
0.16 on its way to CPAN now.
|
|
You are quick on the draw sir. Which makes me all the more embarrassed about the PR i just pushed. /me goes and hides in the corner. |
This updates the repo to match the latest version on CPAN, and it updates the code to pass on 5.37.8.
See Perl/perl5#20710