Remove deprecation warning #21
Conversation
|
Thanks for the patch. :) Looks like CI is stuck/busted (probably a result of the CircleCI 2.0 thing). :( I haven't worked on this project in a while, but I'll hopefully get a chance to fix CI, merge your patch, and fix a few UX + other issues I've been meaning to get to soon. |
See #22. |
|
@srushe If you would be so kind as to rebase this branch, hopefully the retriggered CI should work correctly now (thanks to @bquorning and #22 🎉 ) and I can merge this. |
`Parser::Rewriter` is [deprecated](https://github.com/whitequark/parser/blob/fbe0e8cbec557c96b0e0f4a8c5201155ee478284/lib/parser/rewriter.rb#L6), so we should update to `Parser::TreeRewriter`.
|
Apologies for the delay, I completely missed the comment on rebasing. I've done it just now, but it looks like nothing was kicked off on CircleCI sadly. |
|
@srushe No worries on the delay. :)
That's so odd. Maybe it's still stuck from before somehow. I'm not sure why it won't run but I downloaded your branch and ran the tests locally so I'll just override the CI requirement. Thanks for the fix. |
- As pointed out in #42 (thanks @chiastolite!), `rspectre` uses features from `parser` that are only available in 2.5 (see #21). The APIs that are in use should also be compatible with 3.x and because `parser` is intended to have a permanently stable API (or, as close to that as possible), this can just be changed to >= 2.5 for now.
- As pointed out in #42 (thanks @chiastolite!), `rspectre` uses features from `parser` that are only available in 2.5 (see #21). The APIs that are in use should also be compatible with 3.x and because `parser` is intended to have a permanently stable API (or, as close to that as possible), this can just be changed to >= 2.5 for now.
Parser::Rewriteris deprecated, so we should update toParser::TreeRewriter.